Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elm] Add support for sending headers #1704

Merged
merged 1 commit into from
Dec 31, 2018

Conversation

eriktim
Copy link
Contributor

@eriktim eriktim commented Dec 18, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add support for sending headers with Elm.

@slissner can you give it a try?
@wing328 can you have a look?

@auto-labeler
Copy link

auto-labeler bot commented Dec 18, 2018

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

Please review the labels and make any necessary changes.

@slissner
Copy link

@eriktim hey eric!! Amazing, thanks for your work. I will try it by the end of the week and give you feedback asap.

@hmac hmac mentioned this pull request Dec 23, 2018
4 tasks
@wing328 wing328 merged commit a0e5b74 into OpenAPITools:master Dec 31, 2018
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Dec 31, 2018
* master: (26 commits)
  Delete unused method (OpenAPITools#1744)
  Use JsonNullable wrapper on nullable/x-nullable fields (OpenAPITools#1762)
  Add an option to use reflection in equals, hashCode (Java client) (OpenAPITools#1767)
  [Slim] Encode path to support non-latin characters (OpenAPITools#1687)
  [elm] Add support for sending headers (OpenAPITools#1704)
  Add test case for InlineModelResolver: inline array response (OpenAPITools#1778)
  fix group parameter logic (OpenAPITools#1779)
  Add test case for InlineModelResolver: inline array request body (OpenAPITools#1777)
  Add test case for InlineModelResolver: inline array schema (OpenAPITools#1772)
  Fix type inference error (OpenAPITools#1773)
  skip default value for contaier in spring (OpenAPITools#1725)
  [Slim] Add PHP CodeSniffer config template (OpenAPITools#1764)
  Use CompareNetObject for object comparison in C# client (refactor) (OpenAPITools#1765)
  Add test case for InlineModelResolver (OpenAPITools#1771)
  Add online gen tests (OpenAPITools#1759)
  Resolve inline models before preprocess (OpenAPITools#1761)
  better handling of allOf (composition) (OpenAPITools#1757)
  Fix UUID support (OpenAPITools#1746)
  Use appInfo.version for podspec (OpenAPITools#1760)
  [Swift 4] Add `createURLRequest` method (OpenAPITools#1727)
  ...
@eriktim eriktim deleted the elm-headers branch December 31, 2018 07:22
@wing328
Copy link
Member

wing328 commented Jan 2, 2019

@eriktim thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529.

Happy New Year and looking forward to more collaboration and contributions in 2019!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants